Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable caching of Dokka's integration tests #2826

Merged
merged 2 commits into from Feb 9, 2023

Conversation

IgnatBeresnev
Copy link
Member

Because integration tests are cached by default, it produces no output for showcasing documentation through S3 or GitHub artifacts.

Tried to explain what needs to be done in the comment. I tried, but it takes too much time to implement and test it properly, and I'd like to restore the demo functionality sooner, so proposing to just disable it for now.

Regression from #2711

Because integration tests are cached by default, it produces no output for showcasing documentation through S3 or GitHub artifacts.

Regression from #2711
Copy link
Member

@vmishenev vmishenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the --no-build-cache option work for this?

integration-tests/build.gradle.kts Outdated Show resolved Hide resolved
@IgnatBeresnev
Copy link
Member Author

Does the --no-build-cache option work for this?

Most likely yes, although I haven't checked.

Copy link
Member

@vmishenev vmishenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would try to use --no-build-cache for our actions but you have implemented with @DisableCachingByDefault.

@TWiStErRob
Copy link
Contributor

The argument applies to the whole build, the annotation only to one task.

@IgnatBeresnev
Copy link
Member Author

IgnatBeresnev commented Feb 9, 2023

Not only that, but integration tests are run on TeamCity (I don't think it uses caches, but still) and are also run locally, so we'd have to be using --no-build-cache all the time and probably add it to some of the instructions for external contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants