Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading empty properties by CLI json parser. #2362

Merged
merged 1 commit into from Feb 14, 2022

Conversation

BarkingBad
Copy link
Contributor

The problem was when we used DokkaSourceSetImpl as TypeReference for Jackson object mapper, we could end up with an error:

Exception in thread "main" java.lang.ClassCastException: kotlin.collections.EmptyList cannot be cast to kotlin.collections.MutableList

The issue stems from the default implementation of DokkaSourceSetImpl, that if there is no such property in json, it was returning EmptyList which cannot be cast to MutableList in case of mutating its state for CLI with global options purposes #2292 . The same problem applies to Sets

@vmishenev vmishenev merged commit b0244f6 into Kotlin:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants