Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing external docs for some AndroidX libraries #2456

Merged
merged 2 commits into from Apr 25, 2022
Merged

Fix missing external docs for some AndroidX libraries #2456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7f96af
Fix missing external docs for some AndroidX libraries
EdricChan03 Apr 21, 2022
0ac70b2
Fix tests
EdricChan03 Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/kotlin/defaultExternalLinks.kt
View file
Open in desktop
Expand Up @@ -25,6 +25,6 @@ fun ExternalDocumentationLink.Companion.androidSdk(): ExternalDocumentationLinkI

fun ExternalDocumentationLink.Companion.androidX(): ExternalDocumentationLinkImpl = ExternalDocumentationLink(
url = URL("https://developer.android.com/reference/kotlin/"),
packageListUrl = URL("https://developer.android.com/reference/androidx/package-list")
packageListUrl = URL("https://developer.android.com/reference/kotlin/androidx/package-list")
)

4 changes: 2 additions & 2 deletions ...adle-plugin/src/test/kotlin/org/jetbrains/dokka/gradle/GradleDokkaSourceSetBuilderTest.kt
View file
Open in desktop
Expand Up @@ -412,7 +412,7 @@ class GradleDokkaSourceSetBuilderTest {
}, "Expected android sdk in external documentation links")

assertEquals(1, sourceSet.build().externalDocumentationLinks.count {
"https://developer.android.com/reference/androidx" in it.packageListUrl.toURI().toString()
"https://developer.android.com/reference/kotlin/androidx/package-list" in it.packageListUrl.toURI().toString()
}, "Expected androidx in external documentation links")


Expand All @@ -423,7 +423,7 @@ class GradleDokkaSourceSetBuilderTest {
}, "Expected no android sdk in external documentation links")

assertEquals(0, sourceSet.build().externalDocumentationLinks.count {
"https://developer.android.com/reference/androidx" in it.packageListUrl.toURI().toString()
"https://developer.android.com/reference/kotlin/androidx/package-list" in it.packageListUrl.toURI().toString()
}, "Expected no androidx in external documentation links")
}

Expand Down