Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused & redundant dependencies for Gradle runner #2502

Merged
merged 3 commits into from May 27, 2022
Merged

Remove unused & redundant dependencies for Gradle runner #2502

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08a2a6a
Remove unused jackson-annotations dependency
3flex May 15, 2022
6896617
Remove redundant kotlin-reflect dependency
3flex May 15, 2022
82febe3
Remove redundant dependencies on gradleApi
3flex May 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 0 additions & 11 deletions runners/gradle-plugin/build.gradle.kts
View file
Open in desktop
Expand Up @@ -13,14 +13,10 @@ repositories {
dependencies {
api(project(":core"))

val jackson_version: String by project
compileOnly("com.fasterxml.jackson.core:jackson-annotations:$jackson_version")
compileOnly("org.jetbrains.kotlin:kotlin-gradle-plugin")
compileOnly("com.android.tools.build:gradle:4.0.1")
compileOnly(gradleApi())
compileOnly(gradleKotlinDsl())
testImplementation(project(":test-utils"))
testImplementation(gradleApi())
testImplementation(gradleKotlinDsl())
testImplementation("org.jetbrains.kotlin:kotlin-gradle-plugin")
testImplementation("com.android.tools.build:gradle:4.0.1")
Expand All @@ -32,13 +28,6 @@ dependencies {
.classpath.asFiles.first()
)
)

constraints {
val kotlin_version: String by project
compileOnly("org.jetbrains.kotlin:kotlin-reflect:${kotlin_version}") {
because("kotlin-gradle-plugin and :core both depend on this")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dependency constraint.
It allows to choose needed version of kotlin-reflect from transitive dependencies. Currently it makes no sense because the latest kotlin-gradle-plugin excludes kotlin-reflect.

}
}
}

val sourceJar by tasks.registering(Jar::class) {
Expand Down