Improve handling of Java annotation parameters #2562
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 issues that all came from the same place. See the tests, there's one for each issue.
Fixes #2509
Fixes #2551
Fixes #2350
I've also tried to make it so that it doesn't lead to build failures in case some other corner case is not covered, although it might come with some signature bugs for such situations.
Note
Source code
Will be rendered as
This is probably incorrect and it might be better to generate
Array::class
instead, but I've had a look at how we handle such cases for Kotlin sources and it's actually generatingString::class
, so I think it's better to have the same behaviour for both Kotlin and Java. This is to be discussed and fixed separately as it would require introducing changes to the annotations model.