Add constructor keyword #2691
Merged
Add constructor keyword #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch `fun` keyword to `constructor` for class constructors * remove class name from constructor * remove rendering of modifiers that not applies to constructor
There was a problem hiding this comment.
Good job!
It's better to see something once than to hear about it a thousand times, so I've attached a patch with how I would fix my comments - it's difficult to explain it all in text, so hopefully this saves us some going back and forth, and gives you a general idea. Free free to either apply it fully or modify it to your liking
Patch (for some reason github does not let me attach it as a file, so here's a link): https://github.com/IgnatBeresnev/static/blob/main/patch/2691_test_refactoring.patch
plugins/base/src/test/kotlin/content/functions/ContentForBriefTest.kt
Outdated
Show resolved
Hide resolved
plugins/base/src/test/kotlin/content/functions/ContentForBriefTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
funkeyword toconstructorfor class constructorsfix #2689
probably, bring something to #1930