Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of 'parseWithNormalisedSpaces' that is unconditio… #2730

Merged
merged 1 commit into from Mar 8, 2023

Conversation

qwwdfsad
Copy link
Member

…nally invoked for each HTML text element

Addresses #2729

…nally invoked for each HTML text element

Addresses #2729
@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Mar 8, 2023

I remember we wanted to do some benchmarking of this change, but then we kinda forgot about it and now I'm not sure when I'll have time for it

@qwwdfsad would you be OK if we merge it as is, without additional benchmarking? The code/solution is clear to me, there's a comment, plus there's a very good description in #2729

@qwwdfsad
Copy link
Member Author

qwwdfsad commented Mar 8, 2023

I'm totally good.

It cuts a significant portion of allocations and CPU, but alas the actual execution time is dominated by classloader per task stuff. So the only downside of merging it now is that we won't be able to brag with "we improved performance by 30%" (as if we did it after Worker isolation)

@qwwdfsad qwwdfsad merged commit 6b46d95 into master Mar 8, 2023
@qwwdfsad qwwdfsad deleted the qwwdfsad/speedup branch March 8, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants