Push classlike tabs reorganization research results #2810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnatBeresnev
commented
Jan 12, 2023
| @@ -174,10 +174,7 @@ function initTabs() { | |||
| function showCorrespondingTabBody(element) { | |||
There was a problem hiding this comment.
This whole file is the same as in the original PR
IgnatBeresnev
commented
Jan 12, 2023
| @@ -942,6 +942,7 @@ td.content { | |||
| } | |||
|
|
|||
| .platform-hinted > .content:not([data-active]), | |||
| .tabs-section-body *[data-togglable]:not([data-active]), | |||
There was a problem hiding this comment.
From the original PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bad code ahead, not to be merged, it's just a demonstration of research results in addition to written review
Diff is best viewed from IntelliJ, it will highlight what truly changed. Because of added blocks / extracted methods it might seem like a lot of code was added/deleted, but actually not
Must be closed with #2764