Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated stdlib integration test #2841

Merged
merged 1 commit into from Feb 21, 2023

Conversation

IgnatBeresnev
Copy link
Member

@IgnatBeresnev IgnatBeresnev commented Feb 1, 2023

(for after 1.8.10)

The stdlib integration test is quite problematic:

  • It's using an outdated version of Kotlin 1.4, which we won't be able to support forever.
  • It's using an outdated version of Gradle 5.6, which is already causing compatibility problems (see apply kotlin-dsl plugin #2702)
  • The project used for the integration (added as a git submodule) is not supported anymore (no updates since 2021), and contains non-trivial build configuration, which makes it very costly to update.
  • The test has not helped catch any bugs that weren't detected by coroutines/serialization tests, whereas other KMP libraries such as ktor have caught non-trivial and specific problems.

The test has mostly been used as a live demo / preview of changes in Dokka (see Github Action configuration for S3), which is quite useful, but not needed for every commit.

Stdlib is currently moving towards using modern versions of Dokka, and there already are TeamCity builds that can generate documentation for a modern version of stdlib with any version of Dokka, with the output saved to artifacts. So it will be possible to check compatibility between uo-to-date Dokka and Stdlib, and it will be possible to preview Dokka changes whenever needed and before releases.

@IgnatBeresnev IgnatBeresnev marked this pull request as ready for review February 21, 2023 14:06
@IgnatBeresnev
Copy link
Member Author

Rebased onto master and marked ready for review. This can be merged now.

The release has a separate branch 1.8.10, so it won't affect it.

@IgnatBeresnev IgnatBeresnev merged commit f4a6a6a into master Feb 21, 2023
@IgnatBeresnev IgnatBeresnev deleted the remove-stdlib-integration-test branch February 21, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant