Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test runtime Java versions #2918

Merged
merged 17 commits into from Mar 16, 2023
Merged

Fix test runtime Java versions #2918

merged 17 commits into from Mar 16, 2023

Commits on Mar 13, 2023

  1. Fix test runtime Java versions 

    - Create DokkaBuildProperties extension for convenient sharing values used to configure the Dokka build (only contains 3 values now, but this will be expanded later)
- update base-java convention to set the test Java launcher
- update GitHub workflow to set the java-version via DokkaBuildProperties
    @aSemy
    aSemy committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e021943 View commit details
    Browse the repository at this point in the history

  2. suppress PackageDirectoryMismatch in accessors util

    @aSemy
    aSemy committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c322173 View commit details
    Browse the repository at this point in the history

  3. rename accessors file

    @aSemy
    aSemy committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    fcd57d1 View commit details
    Browse the repository at this point in the history

  4. fix Version typo 

    Co-authored-by: Goooler <wangzongler@gmail.com>
    @aSemy @Goooler
    aSemy and Goooler committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d5ab847 View commit details
    Browse the repository at this point in the history

  5. default testLauncher to mainJavaVersion

    @aSemy
    aSemy committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    f27fa8c View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. use function references instead of lambdas 

    Co-authored-by: Goooler <wangzongler@gmail.com>
    @aSemy @Goooler
    aSemy and Goooler committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    66eb243 View commit details
    Browse the repository at this point in the history

  2. Remove explicit type arguments 

    Co-authored-by: Goooler <wangzongler@gmail.com>
    @aSemy @Goooler
    aSemy and Goooler committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    bf47fd9 View commit details
    Browse the repository at this point in the history

  3. tidy up comment

    @aSemy
    aSemy committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    379ab75 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into fix/test_runtime_ja… 

    …va_version

# Conflicts:
#	build-logic/src/main/kotlin/org/jetbrains/DokkaBuildProperties.kt
#	build-logic/src/main/kotlin/org/jetbrains/conventions/base-java.gradle.kts
#	build-logic/src/main/kotlin/org/jetbrains/internal/gradleKotlinDslAccessors.kt
    @aSemy
    aSemy committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    ed31e35 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Update build-logic/src/main/kotlin/org/jetbrains/conventions/base.gra… 

    …dle.kts

Co-authored-by: Goooler <wangzongler@gmail.com>
    @aSemy @Goooler
    aSemy and Goooler committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    0dc471f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/test_runtime_java_version

    @aSemy
    aSemy committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    8337737 View commit details
    Browse the repository at this point in the history

  3. tweak the 'kotlinx.coroutines requires Java 11' fix

    @aSemy
    aSemy committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    62a38a1 View commit details
    Browse the repository at this point in the history

  4. set useJUnitPlatform() in base-java convention

    @aSemy
    aSemy committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    8f44842 View commit details
    Browse the repository at this point in the history

  5. add JUnit engines for both JUnit 4 and 5

    @aSemy
    aSemy committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    a586e25 View commit details
    Browse the repository at this point in the history

  6. replace useJUnitPlatform() with useJUnit() - aligning and updatin… 

    …g the tests would be a big change that should be done in another PR
    @aSemy
    aSemy committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    a7c81de View commit details
    Browse the repository at this point in the history

  7. use JUnit Platform & add necessary runtime dependencies

    @aSemy
    aSemy committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    8f0ab24 View commit details
    Browse the repository at this point in the history

  8. update TODO comment with more info

    @aSemy
    aSemy committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    bb39de7 View commit details
    Browse the repository at this point in the history