Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test processes to start in parallel #2953

Merged
merged 4 commits into from Apr 26, 2023
Merged

Increase test processes to start in parallel #2953

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da4a778
Execute tests in parallel
Goooler Mar 31, 2023
5facf7e
Use all cores on GHA runners but the half on others
Goooler Mar 31, 2023
b8ffed7
Merge branch 'trunk' into test_in_parallel
Goooler Apr 26, 2023
c9f4aed
Revert changes for integration tests
Goooler Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions build-logic/src/main/kotlin/org/jetbrains/conventions/base-java.gradle.kts
View file
Open in desktop
Expand Up @@ -22,6 +22,12 @@ java {
tasks.withType<Test>().configureEach {
useJUnitPlatform()

maxParallelForks = if (System.getenv("CI") != null) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we can read dokka_integration_test_parallelism like

dokka/build-logic/src/main/kotlin/org/jetbrains/conventions/dokka-integration-test.gradle.kts

Lines 54 to 56 in 3ea4142

project.properties["dokka_integration_test_parallelism"]?.toString()?.toIntOrNull()?.let { parallelism ->
maxParallelForks = parallelism
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more cores in TeamCity runners, maybe we can use

    maxParallelForks = if (System.getenv("GITHUB_ACTIONS") != null) {
        Runtime.getRuntime().availableProcessors()
    } else {
        (Runtime.getRuntime().availableProcessors() / 2).takeIf { it > 0 } ?: 1
    }

for both tests and integrationTests, get rid of dokka_integration_test_parallelism property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5facf7e

Runtime.getRuntime().availableProcessors()
} else {
(Runtime.getRuntime().availableProcessors() / 2).takeIf { it > 0 } ?: 1
}

javaLauncher.set(javaToolchains.launcherFor {
languageVersion.set(dokkaBuild.testJavaLauncherVersion)
})
Expand Down