Update KGP to 1.8.20 #2989
Update KGP to 1.8.20 #2989
Conversation
vmishenev
force-pushed
the
update-kgp-1.8.20
branch
2 times, most recently
from
8548f18
to
665f71d
Compare
vmishenev
force-pushed
the
update-kgp-1.8.20
branch
6 times, most recently
from
44fcaff
to
bac97d8
Compare
vmishenev
force-pushed
the
update-kgp-1.8.20
branch
5 times, most recently
from
554e695
to
e0d6f7a
Compare
vmishenev
force-pushed
the
update-kgp-1.8.20
branch
2 times, most recently
from
3345075
to
168d4e8
Compare
vmishenev
force-pushed
the
update-kgp-1.8.20
branch
from
168d4e8
to
0b957c0
Compare
runners/gradle-plugin/src/main/kotlin/org/jetbrains/dokka/gradle/kotlin/kotlinClasspathUtils.kt
Show resolved
Hide resolved
...e-plugin/src/main/kotlin/org/jetbrains/dokka/gradle/GradleDokkaSourceSetBuilderExtensions.kt
Show resolved
Hide resolved
runners/gradle-plugin/src/main/kotlin/org/jetbrains/dokka/gradle/kotlin/kotlinClasspathUtils.kt
Show resolved
Hide resolved
...ers/gradle-plugin/src/test/kotlin/org/jetbrains/dokka/gradle/AndroidAutoConfigurationTest.kt
Outdated
Show resolved
Hide resolved
| @@ -5,10 +5,11 @@ import org.jetbrains.dokka.model.Documentable | |||
| import org.jetbrains.dokka.model.properties.WithExtraProperties | |||
|
|
|||
| internal fun WithExtraProperties<out Documentable>.hasJvmSynthetic(): Boolean { | |||
| @Suppress("TYPE_MISMATCH_WARNING_FOR_INCORRECT_CAPTURE_APPROXIMATION") | |||
There was a problem hiding this comment.
There was a a comment about this in the draft, and I was under the impression you'd figure it out - any luck?
I personally don't feel comfortable suppressing our own API faults (see the get() operator implementation) without a plan, given that it will be reported as error in Kotlin 2.0
There was a problem hiding this comment.
I think it is not relevant to get(). Here we have a covariant out Documentable (in a particular case with some Captured(out Documentable) type). So there are ExtraProperty.Key<Captured(out Documentable), T> and ExtraProperty.Key<AnnotationTarget, Annotations> at the same time.
Dokka suppresses source sets that do no have compilation since such configuration is invalid, it reports a warning or an error
plugins/base/src/main/kotlin/transformers/documentables/utils.kt
Outdated
Show resolved
Hide resolved
|
I triggered thorough tests manually, but for some reason GitHub is not reporting them as pending / in progress for this PR Let's wait for these to pass before the merge: https://github.com/Kotlin/dokka/actions/runs/5004525443 |
They are triggered only for |
KGP 1.8.20 have increased memory consumption in Dokka project a little (10-20%), It causes memory exhaustion of free GitHub runners in GitHub Actions. (publishing coroutines
##[debug]Node Action run completed with exit code 143and the unit tests on WindowsNative memory allocation (malloc) failed to allocate). The--no-daemonflag does not help anymore in Windows.So stricter memory constraints have been applied to GH actions.
It is based on #2972