Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to get serialized configuration of a task #3008

Merged
merged 3 commits into from May 30, 2023

Conversation

IgnatBeresnev
Copy link
Member

@IgnatBeresnev IgnatBeresnev commented May 23, 2023

A proposal for an intermediate solution for #2873, which should help with debugging configuration and compatibility issues.

cc @aSemy

@aSemy
Copy link
Contributor

aSemy commented May 24, 2023

Ahh clever solution, I like it.

I have a couple of observations.

@IgnatBeresnev
Copy link
Member Author

@aSemy could I ask you to review the PR since you've already had a look? :) I've implemented the pretty print suggestion

@IgnatBeresnev IgnatBeresnev requested a review from aSemy May 26, 2023 18:25
Copy link
Contributor

@aSemy aSemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR, but GitHub won't let me tick the 'Approve' button

image

@IgnatBeresnev
Copy link
Member Author

I was actually wondering about that..

Thanks!

@IgnatBeresnev IgnatBeresnev merged commit 202fa09 into master May 30, 2023
11 checks passed
@IgnatBeresnev IgnatBeresnev deleted the expose-task-json-configuration branch May 30, 2023 18:28
IgnatBeresnev added a commit that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants