Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Analysis API to 2.0.20-dev-7 #3487

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

vmishenev
Copy link
Member

@vmishenev vmishenev commented Feb 5, 2024

Fixed(Blocked by https://youtrack.jetbrains.com/issue/KT-65561/Analysis-API-dummy.kt-is-not-a-physical-file)

Changes:
JetBrains/kotlin@bba5447 : applicationDisposable parameter is removed from buildStandaloneAnalysisAPISession because:

  • It wasn’t used as the actual disposable for the shared application under the hood. In fact, logically it was just a second project disposable.
  • The client should not need to care about application disposal, as signaling that the project is no longer used via the projectDisposable is sufficient.

JetBrains/kotlin@bba5447 : `applicationDisposable` parameter is removed from `buildStandaloneAnalysisAPISession` because:
- It wasn’t used as the actual disposable for the shared application under the hood. In fact, logically it was just a second project disposable.
- The client should not need to care about application disposal, as signaling that the project is no longer used via the projectDisposable is sufficient.
@vmishenev vmishenev changed the title Update Analysis API to 2.0.0-dev-14242 Update Analysis API to 2.0.20-dev-7 Mar 28, 2024
@vmishenev vmishenev marked this pull request as ready for review March 28, 2024 10:00
@vmishenev vmishenev merged commit 31ec638 into master Mar 28, 2024
11 of 13 checks passed
@vmishenev vmishenev deleted the vmishenev/Update-Analysis-API-to-2.0.0-dev-14242 branch March 28, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants