Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #3535 (comment)
Problem
During update of Dokka to latest version (2.0.0-dev-323) in kotlin stdlib I found, that samples are not runnable anymore (playground is not loading)
Example:
Not reproducible with Dokka 1.9.10 and 1.9.20.
After some investigation I found that
scripts/main.js
is different when building with 1.9.20 and 2.0.0-dev-323.After some additional check of older 2.0.0-dev-* versions I found, that the issue started to appear after #3413
If to revert
package-lock.json
changes samples are runnable again:Reproducing
Reproducer project is in PR. It's not an integration test, as it's not possible to render produced HTML there, and as the issue in
js
script there is no way to test it.I've left some comments on how to reproduce the issue n
examples/gradle/dokka-runnable-samples-example/README.md
, will inline here just to understand the idea:Note: better to change the version every time there are some changes happened,
as Gradle caches something badly and so
main.js
could not change in final HTML distribution.To reproduce (from the root of the project):
Everything works fine if to revert commit which changes
package-lock.json
(155efa4):@berezinant Could you take a look?