Update CLI Integration Tests to use JVM Test Suites #3580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-enko
force-pushed
the
KT-64200/cli-jvm-test-suite
branch
from
3d9c6f2
to
c910a42
Compare
- Migrate the CLI integration tests away from the custom integration test convention (which are not build-cache compatible) to use JVM Test Suites.
- Remove shadowing, replace with passing in the JARs via system properties. (a custom CommandLineArgumentProvider is confusing and overly complicated, but it's required to satisfy Gradle input normalization, so that the build-cache can be re-used.)
- Simplify `processUtils.kt` - the coroutines logic isn't necessary since the entrypoint just used `runBlocking {}`.
- move `jsonBuilder.kt` test-util into `src/main`, since it's not a test
- Rename `CliIntegrationTest` to `CliTest` (it wasn't an integration test, and the name was confusing compared to the actual `CliIntegrationTest`)
adam-enko
force-pushed
the
KT-64200/cli-jvm-test-suite
branch
from
c910a42
to
6ca63aa
Compare
adam-enko
added
the
infrastructure
whyoleg
approved these changes
Apr 24, 2024
dokka-integration-tests/utilities/src/main/kotlin/org/jetbrains/dokka/it/processUtils.kt
Outdated
Show resolved
Hide resolved
whyoleg
approved these changes
Apr 25, 2024
dkrasnoff
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of KT-64200
processUtils.kt- the coroutines logic isn't necessary since the entrypoint just usedrunBlocking {}.jsonBuilder.kttest-util intosrc/main, since it's not a testCliIntegrationTesttoCliTest(it wasn't an integration test, and the name was confusing compared to the actualCliIntegrationTest).jsonin the resources directory. I thought this was strange, so I changed it to use a new file created in the JUnit temporary directory.