Allow overriding a Dokka version in integration tests #3585
+76
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnatBeresnev
approved these changes
Apr 29, 2024
whyoleg
force-pushed
the
it-custom-dokka-version
branch
from
199d6be
to
6dbe661
Compare
whyoleg
commented
May 8, 2024
| dokkaBuild.androidSdkDir.orNull?.let { androidSdkDir -> | ||
| environment("ANDROID_HOME", androidSdkDir.invariantSeparatorsPath) | ||
| fun environmentProvider(name: String, provider: Provider<out Any>) { | ||
| inputs.property(name, provider) |
There was a problem hiding this comment.
@adam-enko FYI, without adding properties which are passed to environment to inputs tasks will always stay up-to-date when those properties are changed
berezinant
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An addition for #3583.
For UI showcase project, after PR is merged, it will be possible to run it like this:
It's also possible to add
org.jetbrains.dokka.integration_test.dokkaVersionOverride=2.0.0-dev-329todokka-integration-tests/gradle.properties(but, it's less recommended, as it could be unnoticed and affect tests behaviour)Note: PR is based on master and not
ui-test-projectbranch, sotestUiShowcaseProjectwill be not available.Note regarding implementation:
ui-showcaseproject. Additionally it could be useful for reproducing bugs with older versions if needed via just property;project.versionto overrideDOKKA_VERSIONand then do the logic based on it - but it will cause rebuilding of all artefacts (because ofdevMavenPublish). It's possible to overcome this, but I didn't want to change a lot of code;DOKKA_VERSIONfor detecting some override could cause some unknown issues;additivechange for this specific use case.