This repository has been archived by the owner on Jan 22, 2024. It is now read-only.
JS Test Examples: Move from gradle plugin com.moowork.node to de.solugo.gradle.nodejs #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
com.moowork.nodegradle plugin is incompatible with Gradle 4.6 whenGRADLE_METADATAis used. This makes it fail when used with plugins that use this feature, such as Kotlin/Nativekonangradle plugin.Therefore, when creating a multi-platform project, using the provided examples do not work.
In this PR, I propose to replace this gradle plugin with the
de.solugo.gradle.nodejsplugin, which works as expected on gradle 4.6+.This will provide examples that work in pure Kotlin/JS projects, but also in Kotlin/Everywhere projects.
Note that the
karmaexample is untouched and is the only one that will continue to fail: the example uses thecom.craigburke.karmagradle plugin, which itself depends oncom.moowork.node.This PR fixes the
jasmine,jest,mocha,qunitandjestexamples.