Implementation of timezone databases for Darwin in Kotlin #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
force-pushed
the
pureKotlinDarwin
branch
from
acb34ed
to
92c615c
Compare
dkhalanskyjb
force-pushed
the
pureKotlinLinux
branch
from
e7c1318
to
e3f4d59
Compare
dkhalanskyjb
force-pushed
the
pureKotlinDarwin
branch
from
ca3a699
to
6448e6f
Compare
dkhalanskyjb
force-pushed
the
pureKotlinLinux
branch
from
e3f4d59
to
d86065c
Compare
dkhalanskyjb
force-pushed
the
pureKotlinDarwin
branch
from
6448e6f
to
6b24e5e
Compare
dkhalanskyjb
force-pushed
the
pureKotlinDarwin
branch
from
6b24e5e
to
7d8769f
Compare
dkhalanskyjb
force-pushed
the
pureKotlinDarwin
branch
from
fcdf35e
to
8f2bf15
Compare
dkhalanskyjb
force-pushed
the
pureKotlinDarwin
branch
from
abe00fd
to
dd85c06
Compare
dkhalanskyjb
force-pushed
the
pureKotlinDarwin
branch
from
dd85c06
to
38650e6
Compare
|
@ilya-g, I've rewritten the history to separate the concerns better. |
Using the official implementation of tzinfo as a reference.
It seems like the only reason to use NSDate.date() is to obtain an object. The POSIX implementation is more accurate.
Now, not everything will break, but only the calls to timezone facilities.
dkhalanskyjb
force-pushed
the
pureKotlinDarwin
branch
from
07d3270
to
0f05fdd
Compare
ilya-g
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This almost works. The only issue is that, in the iOS Simulator only, not on actual devices,
NSTimeZoneandkotlinx.datetime.TimeZoneuse different timezone databases with this implementation, so there are some differences between them. During my testing, there was one extra timezone that our library recognized butNSTimeZonedidn't, breakingTimeZone.toNSTimeZone()occasionally.HowardHinnant/date#577 suggests a solution. I tried to implement it, and I think I'm accessing the correct paths, but for some reason, this still doesn't work.
Maybe I'll have to dig into what timezone database iOS Simulator actually uses, or maybe I made a mistake somewhere and will just need to fix our code.
EDIT: turns out, the problem goes beyond different timezone databases, so we'll have to live with it.