Add a Proguard rule for the missing serialization classes #336
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This permits using kotlinx-datetime without kotlinx-serialization on Android without complaints from the build tooling. Fixes #297
|
The reproducer for this issue no longer fails with an error if I publish the library locally with these changes and add a dependency on it. |
ilya-g
approved these changes
Jan 21, 2024
dkhalanskyjb
added a commit
that referenced
this pull request
Feb 13, 2024
This permits using kotlinx-datetime without kotlinx-serialization on Android without complaints from the build tooling. Fixes #297
|
Hello, thank you for the fix! Can we expect a release with these changes soon? |
|
@LouisCAD, yes, a couple more things, and we'll be able to publish a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permits using kotlinx-datetime without kotlinx-serialization on Android without complaints from the build tooling.
Fixes #297