Improve error descriptiveness in the parsing API #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove delayed initialization of parsing for this purpose and document the thrown exception.
dkhalanskyjb
changed the title
qwwdfsad
reviewed
Mar 4, 2024
| throw DateTimeFormatException(e.message!!) | ||
| throw DateTimeFormatException(when (val message = e.message) { | ||
| null -> "The value parsed from '$input' is invalid" | ||
| else -> "$message (when parsing '$input')" |
There was a problem hiding this comment.
Maybe it's worth adding a test or an overload of assertParsingFails that ensures that the input is present in the message
qwwdfsad
approved these changes
Mar 4, 2024
ilya-g
approved these changes
Mar 14, 2024
dkhalanskyjb
deleted the
fix-error-message-on-parsing-several-varlength-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #359
Fixes #361