Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move samples and packages configuration of Dokka to convention plugin #321

Merged
merged 1 commit into from
May 10, 2024

Conversation

whyoleg
Copy link
Contributor

@whyoleg whyoleg commented May 9, 2024

Fixes #210

Note: I've also moved unsafe package hiding to convention plugin, because AFAIU the same idea of not advertising of this API in official documentation will be applied to unsafe APIs in core.

@whyoleg whyoleg requested a review from fzhinkin May 9, 2024 11:13
@whyoleg whyoleg self-assigned this May 9, 2024
Copy link
Collaborator

@fzhinkin fzhinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whyoleg thanks a lot for addressing the issue!

@fzhinkin fzhinkin changed the base branch from master to develop May 10, 2024 08:12
@fzhinkin fzhinkin merged commit 601e5f1 into develop May 10, 2024
1 check passed
@whyoleg whyoleg deleted the dokka-convention branch May 13, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Dokka setup to a separate plugin and make samples discovery flexible
2 participants