Bump Dokka's version with general maintenance #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnatBeresnev
commented
Apr 8, 2022
build.gradle.kts
Outdated
Comment on lines
42
to
44
| languageVersion = "1.3" | ||
| languageVersion = "1.6" | ||
| jvmTarget = "1.8" | ||
| freeCompilerArgs = freeCompilerArgs + listOf("-Xskip-runtime-version-check") |
There was a problem hiding this comment.
- Afaik 1.3 is not supported in 1.6 anymore, so had to bump it. Can change to
1.5or1.4if there's a need for this - Not sure why it was initially added, but I believe
-Xskip-runtime-version-checkis not needed anymore since it's the same version of kotlin and dokka -- there's no error now. Can revert, but would love to know why it's needed then :)
There was a problem hiding this comment.
We have to stick with 1.4, otherwise Gradle 6.x won't be able to consume newer Knit (because it's bundling Kotlin 1.4). You may need -Xsuppress-version-warnings for that.
Regarding 2, sure, it's no longer needed
qwwdfsad
reviewed
Apr 9, 2022
Otherwise Gradle 6.x won't be able to consume newer Knit (because it's bundling Kotlin 1.4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to check that Dokka 1.6.20 is compatible with knit and nothing is broken, so I had to update other dependencies and resolve warnings as well (due to
allWarningsAsErrors).Once Dokka 1.6.20 is released, I can either update this PR (probably sometime next week) or create a separate one, it's up to you whether to merge this now or later :)