Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle to 7.3.3, Kotlin to 1.5.31 #32

Closed
wants to merge 1 commit into from

Conversation

elizarov
Copy link
Contributor

Kotlin is updated to the same version as bundled into Gradle to simplify building Gradle plugin.

Kotlin is updated to the same version as bundled into Gradle to simplify building Gradle plugin.
@@ -39,7 +37,7 @@ allprojects {

tasks.withType<KotlinCompile> {
kotlinOptions.apply {
languageVersion = "1.3"
languageVersion = "1.5" // must be the version that is bundled into the current Gradle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we have to stick with 1.4 LV for a while (you might need -Xsuppress-version-warnings to pass through allWarningsAsErrors though).

Otherwise it won't be actually backwards compatible and any project that is using older version of gradle will get something like "Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.5.0, expected version is 1.4.1"

Copy link
Contributor

@thumannw thumannw Feb 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would be good if Gradle 6 would still be supported.

@qwwdfsad
Copy link
Contributor

qwwdfsad commented Apr 9, 2022

Will be fixed in #40

@qwwdfsad qwwdfsad closed this Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants