Kotlin Multiplatform plugin adapter rewritten to use reflection #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
reviewed
Dec 22, 2021
| val extension = project.extensions.findByType( | ||
| KotlinMultiplatformExtension::class.java | ||
| ) ?: return@safe PluginDirs(emptyList(), emptyList()) | ||
| val extension = |
There was a problem hiding this comment.
This part of the trickery definitely needs some explanation with comments for the sake of future maintainability
There was a problem hiding this comment.
@qwwdfsad, @sandwwraith In addition to the comment, I can move reflection to the fail safe path (save the old code and call the new code only if an ClassNotFoundException appears). Because in most cases the Kover will be declared in the same project as the Kotlin Multiplatform Plugin.
It will be a copy paste, but it will work faster and there will be an example of exactly how the code should work with the reflection.
sandwwraith
approved these changes
Dec 22, 2021
shanshin
force-pushed
the
adapters-fix
branch
from
4b1a92e
to
af8713b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100