Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate new Native memory model into kotlinx-coroutines mainline #2833
Incorporate new Native memory model into kotlinx-coroutines mainline #2833
Changes from 10 commits
8cdafed
206d076
96f7dc1
e052ea1
b343d93
5442a1c
2c8439f
e8a76cf
57d65da
6ee3209
575b468
d87858d
93f8867
79ba184
63877dd
51aa77f
c77e852
a6f2d5c
f8e6661
2da3434
ef2f6fc
3412db3
6ac83ee
f005b54
5564b35
d7e8d79
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below this test, there's another one with
runBlocking
. Shouldn't it also be changed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like all these tests should be indeed
runBlocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean, the one below should be
runBlocking
, but the other ones are fine withrunMtTest
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these tests have to be tested with
runBlocking
as neither of the tests implies actual multithreading