Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Await comply with reactive streams Subscriber rule 2.7 #3360

Merged
merged 6 commits into from Jul 8, 2022
Merged

Await comply with reactive streams Subscriber rule 2.7 #3360

merged 6 commits into from Jul 8, 2022

Commits on Jul 7, 2022

  1. Await comply with reactive streams rule 2.7 

    There is a possibility of race of Subscription.request and
Subscription.cancel methods since cancellation handler could be executed
in a separate thread.
Rule
[2.7](https://github.com/reactive-streams/reactive-streams-jvm/blob/v1.0.3/README.md#2-subscriber-code)
requires Subscription methods to be executed serially.
    @EgorKulbachka
    EgorKulbachka committed Jul 7, 2022
    Copy the full SHA
    5f63dc9 View commit details
    Browse the repository at this point in the history

  2. Use synchronized block to ensure serial execution of subscription met… 

    …hods
    @EgorKulbachka
    EgorKulbachka committed Jul 7, 2022
    Copy the full SHA
    4db2131 View commit details
    Browse the repository at this point in the history

  3. Stress test for await cancel race condition

    @EgorKulbachka
    EgorKulbachka committed Jul 7, 2022
    Copy the full SHA
    90045c4 View commit details
    Browse the repository at this point in the history

  4. Revert await test changes

    @EgorKulbachka
    EgorKulbachka committed Jul 7, 2022
    Copy the full SHA
    179bf3f View commit details
    Browse the repository at this point in the history

  5. Rename test method

    @EgorKulbachka
    EgorKulbachka committed Jul 7, 2022
    Copy the full SHA
    e7a342b View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Rewrite stress test to sequential iterations and including onNext

    @EgorKulbachka
    EgorKulbachka committed Jul 8, 2022
    Copy the full SHA
    947adb8 View commit details
    Browse the repository at this point in the history