Introduce Job.parent API #3384
Merged
Introduce Job.parent API #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The API is crucial for debugger extension and deadlock detection * It enables allows more fluent coroutines hierarchy inspection, e.g. capability to build a list of roots and procrss them top-bottom separately Fixes #3201
dkhalanskyjb
approved these changes
Jul 29, 2022
| * Always returns `null`. | ||
| * @suppress **This an internal API and should not be used from general code.** | ||
| */ | ||
| @Deprecated(level = DeprecationLevel.WARNING, message = message) |
There was a problem hiding this comment.
Does it make sense to add ReplaceWith(null) to allow for automatic replacements in bulk? I don't see the downsides.
There was a problem hiding this comment.
Not really, it rather means that the whole usage of this API is incorrect and it's time to rethink what is written :)
Comment on lines
+124
to
+126
| * Accesses to this property are not idempotent, the property becomes `null` as soon | ||
| * as the job is transitioned to its final state, whether it is cancelled or completed, | ||
| * and all job children are completed. |
There was a problem hiding this comment.
Suggested change
| * Accesses to this property are not idempotent, the property becomes `null` as soon | |
| * as the job is transitioned to its final state, whether it is cancelled or completed, | |
| * and all job children are completed. | |
| * Accesses to this property are not idempotent: the property becomes `null` as soon | |
| * as the job is transitioned to its final state—whether it is cancelled or completed— | |
| * and all job children are completed. |
Do we allow Unicode in comments?
There was a problem hiding this comment.
I would prefer to avoid it, we never know whether Dokka and kotlinlang support it
There was a problem hiding this comment.
This argument cuts both ways: we may treat this as a good chance to find out. I don't care that much though.
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3201