Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DebugProbes performance #3534

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Improve DebugProbes performance #3534

merged 4 commits into from
Feb 1, 2023

Conversation

qwwdfsad
Copy link
Contributor

@qwwdfsad qwwdfsad commented Nov 21, 2022 •
edited

  • Get rid of RW lock that was contended enough on reads to be observable by non-concurrent coroutines-heavy code (up to 30% of throughput on IDEA-specific benchmark)
  • Tweak the code to be DRF in the absence of RW lock
  • Document snapshots' weak consistency guarantee

Fixes #3527

@qwwdfsad qwwdfsad marked this pull request as ready for review November 21, 2022 13:42
dkhalanskyjb
dkhalanskyjb approved these changes Feb 1, 2023
View reviewed changes
kotlinx-coroutines-debug/src/DebugProbes.kt Outdated Show resolved Hide resolved
@qwwdfsad @dkhalanskyjb
Update kotlinx-coroutines-debug/src/DebugProbes.kt
c5a271e 
Co-authored-by: Dmitry Khalanskiy <52952525+dkhalanskyjb@users.noreply.github.com>
@qwwdfsad qwwdfsad merged commit cca82e7 into develop Feb 1, 2023
@qwwdfsad qwwdfsad deleted the debugger-perf branch February 1, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb dkhalanskyjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qwwdfsad @dkhalanskyjb