Introduce a separate slot for stealing tasks into in CoroutineScheduler #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It solves two problems: * Stealing into exclusively owned local queue does no longer require and CAS'es or atomic operations where they were previously not needed. It should save a few cycles on the stealing code path * The overall timing perturbations should be slightly better now: previously it was possible for the stolen task to be immediately got stolen again from the stealer thread because it was actually published to owner's queue, but its submission time was never updated Fixes #3416
qwwdfsad
force-pushed
the
scheduler-improvement
branch
from
ed9c9d9
to
20daaa7
Compare
…the overall code structure
qwwdfsad
force-pushed
the
scheduler-improvement
branch
from
abd2209
to
54f5766
Compare
|
The last commit is the fix for #3418, it was more convenient to do it right in the same branch |
qwwdfsad
force-pushed
the
scheduler-improvement
branch
from
865d0bf
to
6d97bf5
Compare
Previously, a worker thread unconditionally processed tasks from its own local queue, even if tasks were CPU-intensive, but CPU token was not acquired. Fixes #3418
qwwdfsad
force-pushed
the
scheduler-improvement
branch
from
6d97bf5
to
ca035a0
Compare
qwwdfsad
commented
Nov 29, 2022
kotlinx-coroutines-core/jvm/src/scheduling/CoroutineScheduler.kt
Outdated
Show resolved
Hide resolved
Previously, a worker thread unconditionally processed tasks from its own local queue, even if tasks were CPU-intensive, but CPU token was not acquired. Fixes #3418
kotlinx-coroutines-core/jvm/src/scheduling/CoroutineScheduler.kt
Outdated
Show resolved
Hide resolved
kotlinx-coroutines-core/jvm/src/scheduling/CoroutineScheduler.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Dmitry Khalanskiy <52952525+dkhalanskyjb@users.noreply.github.com>
Co-authored-by: Dmitry Khalanskiy <52952525+dkhalanskyjb@users.noreply.github.com>
dkhalanskyjb
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It solves two problems:
Fixes #3416