Adding full list of HTML entities #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext property in Entities enum
…n for text property in Entities enum
e5l
force-pushed
the
populate_html_entities
branch
from
6071705
to
21650f4
Compare
e5l
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Hey @severn-everett, thanks for the PR and sorry for so long delay.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added list of HTML entities (apart from
equals, as that's a function name in the Enum class) and consolidated getter function for text property in Entities enumThis addresses issue #163