Replace custom time handling with kotlin.time.TimeSource #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfhbd
commented
Feb 10, 2024
|
|
||
| data class TimedResult<T>(val result: T, val time: Long) | ||
| val <O : Appendable> TimedValue<O>.out: O |
There was a problem hiding this comment.
What's the reason for this extension? 🤔 You can call result/value directly.
hfhbd
commented
Feb 10, 2024
e5l
requested changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a binary breaking change.
The current implementation of
TagConsumer.measureTimeuses a custom time implementation. With Kotlin 1.9,TimeSourceis finally stable so we can use it instead. This also allows us to useTimedValue.Another advantage: The standard lib also provides a
TimeSource.Monotonicfor WASI, so adding WASI support removes the need to implementcurrentTimeMillisby ourself.