Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with registering default polymorphic serializer #1913

Closed
wants to merge 1 commit into from

Conversation

piotrtomiak
Copy link

It looks like the code was copied and the update deserializer -> serializer was not made in that single place.

The following would throw an exception (but shouldn't):

SerializersModule {
    polymorphicDefaultDeserializer(AutomationActivityV1::class) { AutomationActivityV1Serializer }
    polymorphicDefaultSerializer(AutomationActivityV1::class) { AutomationActivityV1Serializer }
}

whereas the following would not (but should):

SerializersModule {
    polymorphicDefaultSerializer(AutomationActivityV1::class) { AutomationActivityV1Serializer }
    polymorphicDefaultSerializer(AutomationActivityV1::class) { AutomationActivityV1Serializer }
}

It looks like the code was copied and the update `deserializer` -> `serializer` was not made in that single place.

The following would throw an exception (but shouldn't):
```
SerializersModule {
    polymorphicDefaultDeserializer(AutomationActivityV1::class) { AutomationActivityV1Serializer }
    polymorphicDefaultSerializer(AutomationActivityV1::class) { AutomationActivityV1Serializer }
}
```
whereas the following would not (but should):
```
SerializersModule {
    polymorphicDefaultSerializer(AutomationActivityV1::class) { AutomationActivityV1Serializer }
    polymorphicDefaultSerializer(AutomationActivityV1::class) { AutomationActivityV1Serializer }
}
```
@sandwwraith
Copy link
Member

It's already fixed in dev: #1849

@piotrtomiak
Copy link
Author

Sorry, wrongly assumed that master is the development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants