Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate .isNullable in SerialDescriptor builder #2040

Merged
merged 1 commit into from Sep 22, 2022
Merged

Deprecate .isNullable in SerialDescriptor builder #2040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions core/commonMain/src/kotlinx/serialization/descriptors/SerialDescriptors.kt
View file
Open in desktop
Expand Up @@ -240,6 +240,7 @@ public class ClassSerialDescriptorBuilder internal constructor(
* in its [KSerializer] type parameter and handle nulls during encoding and decoding.
*/
@ExperimentalSerializationApi
@Deprecated("isNullable inside buildSerialDescriptor is deprecated. Please use SerialDescriptor.nullable extension on a builder result.", level = DeprecationLevel.ERROR)
public var isNullable: Boolean = false

/**
Expand Down
7 changes: 7 additions & 0 deletions core/commonTest/src/kotlinx/serialization/SerialDescriptorBuilderTest.kt
View file
Open in desktop
Expand Up @@ -87,4 +87,11 @@ class SerialDescriptorBuilderTest {
assertFailsWith<IllegalArgumentException> { PrimitiveSerialDescriptor(" ", PrimitiveKind.STRING) }
assertFailsWith<IllegalArgumentException> { PrimitiveSerialDescriptor("\t", PrimitiveKind.STRING) }
}

@Test
fun testNullableBuild() {
val descriptor = buildClassSerialDescriptor("my.Simple") {}.nullable
assertTrue(descriptor.isNullable)
assertEquals("my.Simple?", descriptor.serialName)
}
}