[NodeBundle] Use flashbag from session

[dannyvw]

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	yes
Fixed tickets

Because of symfony/symfony#36063 the session is now always started. Besides that is the service deprecated in symfony/symfony#36273

[ProfessorKuma]

Hi @, your PR needs some changes

• This PR seems to need a milestone of a minor release.
• your PR title should look like [SomeBundle] Fixed some code

[ProfessorKuma]

Hi @, your PR passed all our requirements.

Thank you for contributing!

[acrobat]

@dannyvw thanks for the PR! But changing a typehint in the constructor is actually a BC break for users extending this listener. It would be better to remove the type of the flashbag constructor parameter (add the correct typehint in comments) and check in the constructor if we receive the session of the flashbag.

• If we receive the session, assign $session->getFlashBag() to $this->flashbag
• If we receive the old parameter (flashbag), trigger a deprecation and still assign it to the property.

You can see an example of this approach int he config controller:

line 65:

KunstmaanBundlesCMS/src/Kunstmaan/ConfigBundle/Controller/ConfigController.php

Line 65 in 87dac63

/* Environment */ $twig,

line 78-80:

KunstmaanBundlesCMS/src/Kunstmaan/ConfigBundle/Controller/ConfigController.php

Lines 78 to 80 in 87dac63

	if ($twig instanceof EngineInterface) {
	@trigger_error('Passing the "@templating" service as the 2nd argument is deprecated since KunstmaanConfigBundle 5.4 and will be replaced by the Twig renderer in KunstmaanConfigBundle 6.0. Injected the "@twig" service instead.', E_USER_DEPRECATED);
	}

Thanks!

[dannyvw]

@acrobat The PR is changed. Not sure about the version. Is this correct?

[acrobat]

The master branch is indeed the correct target! One minor comment about the deprecation message and can you check the styleci comments? Thanks!

[dannyvw]

@acrobat Fixed. Thanks for the quick response.

[acrobat]

Thanks for the PR and the quick fixes @dannyvw!