Fix MinecraftComponentSerializer on 1.20.3 #144
Conversation
| .filter(m -> Modifier.isStatic(m.getModifiers())) | ||
| .filter(m -> CLASS_CHAT_COMPONENT.isAssignableFrom(m.getReturnType())) | ||
| .filter(m -> m.getParameterCount() == 1 && m.getParameterTypes()[0].equals(String.class)) | ||
| .min(Comparator.comparing(Method::getName)) // prefer the #a method |
There was a problem hiding this comment.
Sorting like this seems a little unstable, also it might not work on a Mojang mapped server
There was a problem hiding this comment.
Oh, this is existing code...
There was a problem hiding this comment.
#a is for strict parsing and #b is for lenient parsing on most versions. I don't think this makes a difference, the input is always valid JSON anyways (since it comes from a serializer).
Also, I believe the String serialization methods are never actually used. 1.13+ has JsonElement serialization methods, and all versions except 1.20.3 seem to provide a Gson object anyways.
By the way, 1.20.3 provides multiple methods which match the serializeTree/deserializeTree lookup, but the only difference is a null check in one of them so that doesn't matter either.
(Just pushed a change where I replaced min with findFirst in deserializeTree because that was a copy-paste error. The line you commented on is still the same.)
|
These fixes work for me on 1.20.3/4 and Im already using it, as without it the library degrades to minimal functionality Tested with cloud help menu on Minecraft 1.8, 1.13, 1.16.5, 1.19.4, 1.20.2 and 1.20.4. |
|
Has this been tested to even work back on 1.7.10 when CB shipped relocated gson? |
This wouldn't be a new issue caused by these changes tho? It used JsonElement and types from gson before |
Seems like there is a small oversight that breaks 1.7.10. This PR only checks subclasses, but on 1.7.10, ChatSerializer itself contains the needed methods. I'll push a fix tomorrow. |
ChatSerializerno longer implementsJsonDeserializer, it uses codecs instead.MinecraftComponentSerializerexpects the serialization methods to be in a subclass which implementsJsonDeserializer.This change makes it look for these methods in all subclasses instead of just that one.
Additionally, it makes it look for serialization methods which use
JsonElementinstead ofString.The previous approach of using
MC_TEXT_GSONto avoid converting viaStringdoesn't work in 1.20.3,ChatSerializerno longer provides a Gson object with the type adapter.