Added legacy show achievements #890
Merged
+57
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zml2008
requested changes
Apr 24, 2023
api/src/main/java/net/kyori/adventure/text/event/HoverEvent.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/event/HoverEvent.java
Outdated
Show resolved
Hide resolved
|
There you go :) |
zml2008
previously approved these changes
May 2, 2023
kashike
previously approved these changes
May 5, 2023
emilyy-dev
suggested changes
May 5, 2023
...erializer-gson/src/main/java/net/kyori/adventure/text/serializer/gson/SerializerFactory.java
Outdated
Show resolved
Hide resolved
...erializer-gson/src/main/java/net/kyori/adventure/text/serializer/gson/SerializerFactory.java
Outdated
Show resolved
Hide resolved
...-serializer-gson/src/main/java/net/kyori/adventure/text/serializer/gson/StyleSerializer.java
Outdated
Show resolved
Hide resolved
zml2008
dismissed
their stale review
retracted pending resolution of @emilyy-dev's review comments
|
There you go (again) |
zml2008
requested changes
May 6, 2023
...-serializer-gson/src/main/java/net/kyori/adventure/text/serializer/gson/StyleSerializer.java
Show resolved
Hide resolved
|
And again :) |
emilyy-dev
reviewed
May 6, 2023
...-serializer-gson/src/main/java/net/kyori/adventure/text/serializer/gson/StyleSerializer.java
Outdated
Show resolved
Hide resolved
zml2008
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Minecraft 1.12, there is a hover event action called
show_achievement.Here's an example of it:
{"action":"show_achievement","value":"achievement.bakeCake"}This PR adds legacy support to it.
Vanilla clients on or after 1.12 can silently ignore these hover events, so there should be no need to deliberately remove them if someone were to send them to modern clients.