Update Spack to 0.22 #272
Update Spack to 0.22 #272
Conversation
… issue with exporting mpi and openmp through new blt interface
…nstall function to help prevent TPL build fails, updated tpl-managers exec call and added C++ TPL versions back
…rnals for blueOS package
| if(ENABLE_STATIC_TPL) | ||
| string(REPLACE ".so" ".a;" ${lib_name}_libs ${${lib_name}_libs}) | ||
| endif() |
There was a problem hiding this comment.
I'm pretty sure ALE3D use EANBLE_STATIC_TPL, is that still the case @ptsuji ?
There was a problem hiding this comment.
Maybe @brbass is using this too?
There was a problem hiding this comment.
Yes, we're using ENABLE_STATIC_TPL.
There was a problem hiding this comment.
We don't need to explicitly bring zlib in as a target so we don't use this file anymore. The zlib tpl is included in the CMAKE_PREFIX_PATH instead.
Co-authored-by: Michael Davis <davis291@llnl.gov>
Co-authored-by: Michael Davis <davis291@llnl.gov>
…into update/update_TPLs
…ript to stop scipy from using the wrong pkg-config on the CZ
| @@ -83,8 +82,6 @@ if(ENABLE_CUDA) | |||
| list(APPEND SPHERAL_CXX_DEPENDS cuda) | |||
| endif() | |||
|
|
|||
| option(BOOST_HEADER_ONLY "only use the header only components of Boost" OFF) | |||
There was a problem hiding this comment.
We use the header-only boost option, is it being removed because it's the default?
There was a problem hiding this comment.
It was thought to be unnecessary since we no longer build boost with cmake. Does it actually make a difference for your builds?
| @@ -89,7 +89,7 @@ foreach(_comp ${AXOM_COMPONENTS_ENABLED}) | |||
| endforeach() | |||
|
|
|||
| # TPLs that must be imported | |||
| list(APPEND SPHERAL_EXTERN_LIBS zlib boost eigen qhull silo hdf5 polytope) | |||
| list(APPEND SPHERAL_EXTERN_LIBS boost eigen qhull silo hdf5 polytope) | |||
There was a problem hiding this comment.
We build our own zlib to link to, is this being removed because the system zlib will be used?
There was a problem hiding this comment.
The zlib path will be included in the CMAKE_PREFIX_PATH in the cmake file created when running TPL. But the zlib target isn't explicitly used when building Spheral.
…ckage configurations
…ing double quotes around spec
There was a problem hiding this comment.
Good work on getting through this slog, hopefully we can start to update more regularly and avoid such a heavy lift in the future. Just a couple of questions and one change request in terms of our upstream directory name. I hope it isn't too much of a pain to move ...
Summary
ToDo :
RELEASE_NOTES.mdwith notable changes.