Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes for P-alpha constructor and ASPH algorithm #274

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Bugfixes for P-alpha constructor and ASPH algorithm #274

wants to merge 4 commits into from

Conversation

jmikeowen
Copy link
Collaborator

@jmikeowen jmikeowen commented May 15, 2024 •
edited

Summary

  • This PR is a bugfix
  • It does the following:
    • Removes an erroneous VERIFY from the Field constructor of PalphaPorosity which forbids valid ranges of parameters
    • Fixes a bug in the SPHHydro that affects ASPH only. But ASPH runs using the SPH hydro have been broken (non-conservative, yielding incorrect answers).

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@jmikeowen
Fixing an erroneous range check in Palpha porosity that was supposed …
a82a07d 
…to be deleted
@jmikeowen
Fixed a terrible bug that was causing standard ASPH hydros (not FSI or
8199070 
CRK) to be incorrect with non-unit aspect ratio H tensors.  Not the
purpose of this branch, but we want this fix in develop ASAP so it
will come along.
@jmikeowen
Adding optional user specified smoothing scale method for SPH, FSISPH,
b53b1ab 
and CRKSPH
@jmikeowen
RZ CRK fix
c7e1360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jmikeowen