Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update next to v14.2.3 #1022

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update next to v14.2.3 #1022

wants to merge 5 commits into from

Conversation

daanboer
Copy link
Contributor

@daanboer daanboer commented May 10, 2024

Includes accompanying updates to swc-plugin-coverage-instrument and playwright.

Closes #860
Closes #1031

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.88%. Comparing base (67c1f72) to head (7c492f2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1022   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files         181      181           
  Lines        8569     8569           
  Branches      889      889           
=======================================
  Hits         7102     7102           
  Misses       1423     1423           
  Partials       44       44           
Flag Coverage Δ
app 60.75% <ø> (ø)
converter 64.82% <ø> (ø)
database 82.39% <ø> (ø)
schema 92.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Error: Can't call test() inside a describe() suite of a different test type.
@daanboer
Copy link
Contributor Author

The citation-js packages seem to be the source of the build errors. They don't play nice with the new next version.

This seems to resolve the problems with `citation-js`. However,
this is not a longterm solution as the option to disable
`swcMinify` will be removed in `v15`.
@daanboer
Copy link
Contributor Author

The issue is related to citation-js packages in combination with swcMinify, see vercel/next.js#46887. The issue is now fixed and waiting to be merged in vercel/next.js#65450. Once this PR is merged we can (temporarily) switch to canary and remove swcMinify: false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant