Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug on an iPhone 4S #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhaoxiaobao
Copy link

No description provided.

@chenliming777
Copy link

这确实是个问题,但代码里面已经提供了相应的对策(自动降级)。

这样改吧

  • (void)setSessionPreset:(LFLiveVideoSessionPreset)sessionPreset{
    _sessionPreset = [self supportSessionPreset:sessionPreset];
    }

f8c5b260-3fa0-42e9-a8d6-cc8b715470ec

@chenliming777
Copy link

你那边测一下吧(LFLiveVideoConfiguration.m 添加下面代码,有问题随时交流)

  • (void)setSessionPreset:(LFLiveVideoSessionPreset)sessionPreset{
    _sessionPreset = [self supportSessionPreset:sessionPreset];
    }

@zhaoxiaobao
Copy link
Author

我测试了,判断语句没有执行。我在4s强制降级,也出现如下异常。

2016-08-04 5 12 50

2016-08-04 5 14 30

@chenliming777
Copy link

chenliming777 commented Aug 5, 2016

这个我上午修复了,按照你那样改数据可能有问题(LFLiveVideoConfiguration),然后目前策略还是自动降级,之前没有测试过😄,你更新下最新代码试试吧。很感谢你发现了这个问题。

@akovalov
Copy link

Could you please update the status of this PR to clean up pull requests list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants