Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update form_content.blade.php #3221

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Conversation

vonsogt
Copy link
Contributor

@vonsogt vonsogt commented Sep 26, 2020

When the field have a prefix or suffix it will not show the validation warning, after added d-block class it will show like it should

Before:
before-fixed

After:
after-fixed

References: twbs/bootstrap#23454

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@tabacitu tabacitu requested a review from pxpm September 28, 2020 09:56
@tabacitu tabacitu added the Possible Bug A bug that was reported but not confirmed yet. label Sep 28, 2020
@tabacitu tabacitu added this to In progress in 🔁 Backpack v4.1.x (Continuous Dev) via automation Sep 28, 2020
@pxpm
Copy link
Contributor

pxpm commented Sep 28, 2020

Indeed this is a problem.

I am not sure if this should be fixed on our side. Thanks for the reference in bootstrap repository.

I followed some issues there and found that the css display:block in an invalid-feedback class was already merged.

Maybe we need to update our bootstrap build ?

Refs: https://github.com/comic/grand-challenge.org/pull/649/files

@tabacitu tabacitu merged commit d55ff89 into Laravel-Backpack:master Sep 28, 2020
🔁 Backpack v4.1.x (Continuous Dev) automation moved this from In progress to Done Sep 28, 2020
@tabacitu
Copy link
Member

Excellent! Thanks @vonsogt & @pxpm ! Will be released later today or tomorrow as a patch update.

@vonsogt vonsogt deleted the patch-3 branch September 28, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Possible Bug A bug that was reported but not confirmed yet.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants