Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of code examples updated and their formatting made consistent #478

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tomsb
Copy link
Contributor

@tomsb tomsb commented Jul 26, 2023

No description provided.

@pxpm
Copy link
Contributor

pxpm commented Jul 26, 2023

Hey @tomsb thanks for the PR 🙏

The only thing I think we should merge is the fix in the join example by changing select (the name of the column we use in demo 🙃 by category_id, what makes sense in a real project.

Can you please clean up this PR a leave only that change ?

We can discuss the other later, but I really don't think they are worth poluting the docs with.

Once again, thank you very much 🙏

Cheers

@pxpm pxpm self-assigned this Jul 26, 2023
…s within the limit", so that they are not polluting the docs
@tomsb
Copy link
Contributor Author

tomsb commented Jul 27, 2023

Removed the polluting stuff, but the other changes look good (some formatting and bug fixes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants