Fix typos and make minor edits #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typos and make minor edits. The phrase "This B solution" seems to be in the wrong place or is no longer relevant, so I removed it. However, I am not sure about this. I rewrote the sentences about why somebody might not like Backpack. I think it is better not to use that kind of negative phrasing in your documentation. The phrasing I have used is more neutral and concentrates of "use" rather than "not like".
|
Actually that public publish step is completely removed in Backpack v6. Backpack starting v6 uses https://github.com/Laravel-Backpack/basset Can you remove the changes done in the publishing step and keep the others so that I can merge them, and I will find time to re-write that bit of docs. The asset are in the files that use them as they include the cdn link. Cheers |
|
@pxpm I hope that I have removed the changes you mentioned correctly. Thanks. |
|
Perfect @peterhauke Really appreciate the effort 🙏 Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos and make minor edits.
The phrase "This B solution" seems to be in the wrong place or is no longer relevant, so I removed it. However, I am not sure about this.
I rewrote the sentences about why somebody might not like Backpack. I think it is better not to use that kind of negative phrasing in your documentation. The phrasing I have used is more neutral and concentrates of "use" rather than "not like".