Using correct filenames for vorbis files #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savify/savify.py
Outdated
| output_temp = output_temp.replace('%(ext)s', self.download_format) | ||
| output_temp = output_temp.replace( | ||
| '%(ext)s', | ||
| download_extension_map.get(self.download_format, self.download_format), |
There was a problem hiding this comment.
There's an error line 246. It should be:
output_temp = output_temp.replace('%(ext)s', format_extension_map.get(self.download_format, self.download_format),)
There was a problem hiding this comment.
youre right, idk where this comes from - fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading songs as ogg/vorbis, the format specified on the command line is
vorbis. However, files of this type have the extension.ogg, so.{download_format}will not work (this will look for a file called{id}.vorbis, which it of course cannot find, and redownload the same songs over and over again).This pull request introduces a map of format names to file extensions, currently only populated with vorbis->ogg. All formats not found in this map will be used as an extension like previously.