fix(tofu): ClassProperty nodes are not globals

Adds an exception to `findGlobals()` for AST nodes of type `ClassProperty`. Closes #1098
LavaMoat · Mar 12, 2024 · ca63a99 · ca63a99
1 parent 7d89d0c
commit ca63a99
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/packages/tofu/src/findGlobals.js b/packages/tofu/src/findGlobals.js
@@ -84,6 +84,11 @@ function findGlobals(ast) {
         return
       }
 
+      // class props are not globals
+      if (parentType === 'ClassProperty' && path.parent.key === path.node) {
+        return
+      }
+
       // save global
       saveGlobal(path)
     },

diff --git a/packages/tofu/test/inspectGlobals.spec.js b/packages/tofu/test/inspectGlobals.spec.js
@@ -430,6 +430,21 @@ testInspect(
   }
 )
 
+testInspect(
+  'class properties',
+  {},
+  () => {
+    class X {
+      y = 123
+      z
+      why() {
+        return this.y
+      }
+    }
+  },
+  {}
+)
+
 function testInspect(label, opts, fn, expectedResultObj) {
   test(label, (t) => {
     const src = fnToCodeBlock(fn)