Skip to content

Commit

Permalink
chore: move corepack to optionalDependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
boneskull committed Aug 21, 2023
1 parent 9fe17b4 commit d950e19
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 23 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ jobs:
with:
useRollingCache: true
install-command: npm ci --foreground-scripts
- name: Upgrade corepack
if: matrix.node-version != '14.x'
run: npm i -g corepack@latest
- name: Lint
run: npm run lint
- name: Test
Expand Down
39 changes: 21 additions & 18 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,12 @@
"lerna": "^7.1.4",
"lint-staged": "^13.2.3"
},
"optionalDependencies": {
"corepack": "0.19.0"
},
"engines": {
"node": ">=14.0.0"
"node": ">=14.0.0",
"npm": ">=7.0.0"
},
"scripts": {
"test": "npm --workspaces test",
Expand Down
1 change: 0 additions & 1 deletion packages/node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
},
"devDependencies": {
"@metamask/eslint-config-nodejs": "^11.0.1",
"corepack": "^0.17.2",
"eslint-plugin-ava": "^13.2.0",
"eslint-plugin-node": "^11.1.0"
},
Expand Down

0 comments on commit d950e19

Please sign in to comment.