Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tofu): ClassProperty nodes are not globals #1099

Merged
merged 2 commits into from Mar 12, 2024
Merged

fix(tofu): ClassProperty nodes are not globals #1099

merged 2 commits into from Mar 12, 2024

Conversation

boneskull
Copy link
Contributor

Adds an exception to findGlobals() for AST nodes of type ClassProperty.

Closes #1098

@boneskull
fix(tofu): ClassProperty nodes are not globals
53f9b90 
Adds an exception to `findGlobals()` for AST nodes of type `ClassProperty`.

Closes #1098
@boneskull boneskull requested a review from a team as a code owner March 12, 2024 20:40
naugtur
naugtur approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@naugtur naugtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@github-actions github-actions bot added the pkg:lavamoat-tofu Changes in package lavamoat-tofu label Mar 12, 2024
@github-actions github-actions bot added the pkg:lavamoat-browserify Changes in package lavamoat-browserify label Mar 12, 2024
@boneskull boneskull merged commit 5ae6734 into main Mar 12, 2024
16 checks passed
@boneskull boneskull deleted the boneskull/issue1098 branch March 12, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naugtur naugtur naugtur approved these changes

Assignees

@boneskull boneskull

Labels
pkg:lavamoat-browserify Changes in package lavamoat-browserify pkg:lavamoat-tofu Changes in package lavamoat-tofu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tofu: support class properties
2 participants
@boneskull @naugtur