unbreak Node.js 20 #495
Closed
unbreak Node.js 20 #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Next error doesn't seem as easy as bumping deps |
legobeat
force-pushed
the
unbreak-node-18
branch
3 times, most recently
from
23f1488
to
f6c6400
Compare
naugtur
reviewed
May 8, 2023
legobeat
force-pushed
the
unbreak-node-18
branch
5 times, most recently
from
1a5e7a8
to
de4ff79
Compare
legobeat
force-pushed
the
unbreak-node-18
branch
2 times, most recently
from
48959a1
to
ff0501e
Compare
legobeat
force-pushed
the
unbreak-node-18
branch
4 times, most recently
from
18bfd5b
to
adb8be0
Compare
|
Removed unrelated commits which have been folded into other currently open PRs. |
|
Since builds aren't kept forever, here's a gist of the failures. UPDATE Maybe that's something else entirely. I'm not sure what's going on in that test. It's from my rebased copy of this branch which should have removed the engines restrictions... |
|
Superseded by #718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#487 (run ci on node v18 and v20) unearthed some regressions. This aims to resolve that.
source-mappackages