Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node.js 18 #551

Merged
merged 3 commits into from May 11, 2023
Merged

Support Node.js 18 #551

merged 3 commits into from May 11, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 11, 2023

  • Enable node.js 18.x in CI
  • lavapack, browserify: bump deps necessary to unbreak node.js 18:
  • core/tests: Add WebAssembly to scuttleGlobalThis.exceptions in tests
    • Required to pass under node.js 18
  • Note that under under certain conditions, running with scuttling enabled requires the following configuration change from:
{
  "scuttleGlobalThis": {
    "exceptions": []
  }
}

to:

{
  "scuttleGlobalThis": {
    "exceptions": ["WebAssembly"]
  }
}

@legobeat legobeat force-pushed the node-18 branch 2 times, most recently from 9cd35d6 to 2b6fc43 Compare May 11, 2023 09:20
@legobeat legobeat requested a review from weizman May 11, 2023 09:23
@legobeat legobeat marked this pull request as ready for review May 11, 2023 09:38
@legobeat legobeat requested a review from a team May 11, 2023 09:39
@legobeat legobeat merged commit 234868d into LavaMoat:main May 11, 2023
5 checks passed
@naugtur naugtur mentioned this pull request May 15, 2023
naugtur added a commit that referenced this pull request May 15, 2023
 - restrict engines.node to < 19.0.0 (#552)
 - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 (#551)
 - Skip JSON files only for policy generation instead of limiting to js files. Current allowlist: cjs,js,mjs,ts (#474)
 - core/fix - remove console taming to that errors are logged to the console correctly (#493)
 - core: fix globalThis polyfill (#567)
 - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463)
 - drop uneeded additionalOpts arg and migrate back into using scenario object (#471)
 - Wrap getters calling with try catch (#468)
 - Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur added a commit that referenced this pull request May 15, 2023
 - restrict engines.node to < 19.0.0 (#552)
 - Add `WebAssembly` scuttle globalThis exceptions - this is necessary as of Node.js 18 (#551)
 - Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - core/fix - remove console taming to that errors are logged to the console correctly (#493)
 - core: fix globalThis polyfill (#567)
 - Fix uncaught error when receiver is null in getPropertyDescriptorDeep (#463)
 - drop uneeded additionalOpts arg and migrate back into using scenario object (#471)
 - Wrap getters calling with try catch (#468)
 - Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur added a commit that referenced this pull request May 15, 2023
 - fix: Restrict `engines.node` to < 19.0.0 (#552)
 - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
 - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - fix: Remove console taming so that errors are logged to the console correctly (#493)
 - fix: Fix globalThis polyfill (#567)
 - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
 - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
 - fix: Catch errors thrown when calling property getters (#468)
 - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
naugtur added a commit that referenced this pull request May 15, 2023
 - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
 - fix: Restrict `engines.node` to < 19.0.0 (#552)
 - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
 - fix: Remove console taming so that errors are logged to the console correctly (#493)
 - fix: Fix globalThis polyfill (#567)
 - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
 - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
 - fix: Catch errors thrown when calling property getters (#468)
legobeat added a commit that referenced this pull request May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576)
  - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
  - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
  - fix: Restrict `engines.node` to < 19.0.0 (#552)                                                - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
  - fix: Remove console taming so that errors are logged to the console correctly (#493)
  - fix: Fix globalThis polyfill (#567)                                                            - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
  - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
  - fix: Catch errors thrown when calling property getters (#468)
- deps: dependency maintenance bumps
  - json-stable-stringify@^1.0.1->^1.0.2
  - convert-source-map@^1.9.0->^2.0.0
  - espree@^7.3.0->^9.5.2
legobeat pushed a commit that referenced this pull request May 15, 2023
 - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
 - fix: Restrict `engines.node` to < 19.0.0 (#552)
 - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
 - fix: Remove console taming so that errors are logged to the console correctly (#493)
 - fix: Fix globalThis polyfill (#567)
 - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
 - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
 - fix: Catch errors thrown when calling property getters (#468)
legobeat added a commit that referenced this pull request May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576)
  - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
  - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
  - fix: Restrict `engines.node` to < 19.0.0 (#552)                                                - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
  - fix: Remove console taming so that errors are logged to the console correctly (#493)
  - fix: Fix globalThis polyfill (#567)                                                            - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
  - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
  - fix: Catch errors thrown when calling property getters (#468)
- deps: dependency maintenance bumps
  - json-stable-stringify@^1.0.1->^1.0.2
  - convert-source-map@^1.9.0->^2.0.0
  - espree@^7.3.0->^9.5.2
legobeat pushed a commit that referenced this pull request May 15, 2023
- change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
- change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
- fix: Restrict `engines.node` to < 19.0.0 (#552)
- fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
- fix: Remove console taming so that errors are logged to the console correctly (#493)
- fix: Fix globalThis polyfill (#567)
- fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
- fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
- fix: Catch errors thrown when calling property getters (#468)
- deps: remove object.fromentries, fromentries
legobeat added a commit that referenced this pull request May 15, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576)
  - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
  - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
  - fix: Restrict `engines.node` to < 19.0.0 (#552)                                                - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
  - fix: Remove console taming so that errors are logged to the console correctly (#493)
  - fix: Fix globalThis polyfill (#567)                                                            - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
  - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
  - fix: Catch errors thrown when calling property getters (#468)
- deps: dependency maintenance bumps
  - json-stable-stringify@^1.0.1->^1.0.2
  - convert-source-map@^1.9.0->^2.0.0
  - espree@^7.3.0->^9.5.2
naugtur added a commit that referenced this pull request May 17, 2023
 - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
 - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
 - fix: Restrict `engines.node` to < 19.0.0 (#552)
 - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
 - fix: Remove console taming so that errors are logged to the console correctly (#493)
 - fix: Fix globalThis polyfill (#567)
 - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
 - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
 - fix: Catch errors thrown when calling property getters (#468)
legobeat added a commit that referenced this pull request May 17, 2023
- deps: lavamoat-core@14.0.0->14.1.0 (#576)
  - change: Policy generation now looks at .cjs, .mjs, .ts and .js files as opposed to only .js files (#474)
  - change: Deprecate `global`,`self` as aliases for `globalThis` (#461)
  - fix: Restrict `engines.node` to < 19.0.0 (#552)                                                - fix: Add `WebAssembly` to scuttle globalThis exceptions. This is necessary as of Node.js 18 (#551)
  - fix: Remove console taming so that errors are logged to the console correctly (#493)
  - fix: Fix globalThis polyfill (#567)                                                            - fix: Handle error when receiver is null in getPropertyDescriptorDeep (#463)
  - fix: Drop unnecessary additionalOpts arg and migrate back into using scenario object (#471)
  - fix: Catch errors thrown when calling property getters (#468)
- deps: dependency maintenance bumps
  - json-stable-stringify@^1.0.1->^1.0.2
  - convert-source-map@^1.9.0->^2.0.0
  - espree@^7.3.0->^9.5.2
legobeat pushed a commit that referenced this pull request Jun 2, 2023
- fix: Node.js 18 compatibility (#551)
- deps: update lavamoat-core@^12.4.0->^14.1.1
- deps: @lavamoat/lavapack@^3.3.0->^5.1.2
- doc: update examples and docs (#476)
- change: Add back policyDebug option (#440)
legobeat pushed a commit that referenced this pull request Jun 2, 2023
- fix: Node.js 18 compatibility (#551)
- deps: update lavamoat-core@^12.4.0->^14.1.1
- deps: @lavamoat/lavapack@^3.3.0->^5.1.2
- doc: update examples and docs (#476)
- change: Add back policyDebug option (#440)
legobeat added a commit that referenced this pull request Jun 2, 2023
- fix: Node.js 18 compatibility (#551)
- deps: lavamoat-core@^12.3.0->^14.1.1
- deps: bump @babel packages to latest (#587)
- deps: bump json-stable-stringify, node-gyp-build, resolve, yargs (#556)
- deps: remove object.fromentries (#555)
- change: BREAKING: Minimum Node.js version 14 (#398)
- fix: Properly add scuttling functionality (#382, #391)
- change: update examples
@legobeat legobeat mentioned this pull request Jun 2, 2023
legobeat pushed a commit that referenced this pull request Jun 6, 2023
- fix: Node.js 18 compatibility (#551)
- deps: update lavamoat-core@^12.4.0->^14.1.1
- deps: @lavamoat/lavapack@^3.3.0->^5.1.2
- doc: update examples and docs (#476)
- change: Add back policyDebug option (#440)
legobeat pushed a commit that referenced this pull request Jun 6, 2023
- fix: Node.js 18 compatibility (#551)
- deps: update lavamoat-core@^12.4.0->^14.1.1
- deps: @lavamoat/lavapack@^3.3.0->^5.1.2
- doc: update examples and docs (#476)
- change: Add back policyDebug option (#440)
boneskull pushed a commit to boneskull/LavaMoat that referenced this pull request Feb 6, 2024
- fix: Node.js 18 compatibility (LavaMoat#551)
- deps: lavamoat-core@^12.3.0->^14.1.1
- deps: bump @babel packages to latest (LavaMoat#587)
- deps: bump json-stable-stringify, node-gyp-build, resolve, yargs (LavaMoat#556)
- deps: remove object.fromentries (LavaMoat#555)
- change: BREAKING: Minimum Node.js version 14 (LavaMoat#398)
- fix: Properly add scuttling functionality (LavaMoat#382, LavaMoat#391)
- change: update examples
boneskull pushed a commit to boneskull/LavaMoat that referenced this pull request Feb 6, 2024
- fix: Node.js 18 compatibility (LavaMoat#551)
- deps: update lavamoat-core@^12.4.0->^14.1.1
- deps: @lavamoat/lavapack@^3.3.0->^5.1.2
- doc: update examples and docs (LavaMoat#476)
- change: Add back policyDebug option (LavaMoat#440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants